[PyROOT] Move CPython extensions in subdirectories #15310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
Test Results 19 files 19 suites 3d 10h 46m 13s ⏱️ Results for commit 0e277c3. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
issue-14917
branch
3 times, most recently
from
5bcf33c to
15e6162
Compare
guitargeek
force-pushed
the
issue-14917
branch
2 times, most recently
from
dc560e3 to
9e24937
Compare
guitargeek
force-pushed
the
issue-14917
branch
from
1d3a0c8 to
760027a
Compare
|
I am re-running all tests since we had some failures a while ago. |
dpiparo
approved these changes
Aug 26, 2024
|
@guitargeek it seems this generates several segfaults, basically on all plarforms, but only for some tests: do you manage to make sense of those? |
guitargeek
force-pushed
the
issue-14917
branch
3 times, most recently
from
0a70e44 to
dc94d64
Compare
guitargeek
force-pushed
the
issue-14917
branch
from
dc94d64 to
cae535e
Compare
guitargeek
force-pushed
the
issue-14917
branch
4 times, most recently
from
f786a65 to
2dffbee
Compare
Only the TerminalInteractiveShell will use the input hooks that are registered via terminal.pt_inputhooks, so for other shells the `%gui ROOT` magic command will not do anything anyway. It's better to not run it then, in order to avoid errors about the `ROOT` gui not being available.
guitargeek
force-pushed
the
issue-14917
branch
2 times, most recently
from
296168e to
0e277c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14917.